Skip to content

Conversation

simolus3
Copy link
Contributor

@simolus3 simolus3 commented Mar 4, 2025

This adds a NodeJS implementation based on the amazing work done by @spinda in this fork. I've followed up on that work by:

  1. Offloading queries to workers, which allows concurrent readers.
  2. Automatically downloading the prebuilt PowerSync core extension in an install script, and loading it when databases are opened (that seemed like the simplest option for now, bundling the shared libraries with the package would probably be a better approach).
  3. Adding a small demo and beginning with a few simple tests.

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 87179ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@powersync/node Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some very minor comments. Overall this looks great to me.

@simolus3 simolus3 marked this pull request as ready for review March 5, 2025 10:44
@simolus3
Copy link
Contributor Author

simolus3 commented Mar 5, 2025

I ran the web tests locally, they still pass.

benitav
benitav previously approved these changes Mar 12, 2025
stevensJourney
stevensJourney previously approved these changes Mar 13, 2025
@benitav benitav dismissed stale reviews from stevensJourney and themself via 2b0f13a March 13, 2025 07:52
@simolus3 simolus3 merged commit 5d602a4 into main Mar 13, 2025
6 checks passed
@simolus3 simolus3 deleted the node branch March 13, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants